-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: add feature gate support #3024
base: master
Are you sure you want to change the base?
Conversation
Allow APIs to be gated conditionally. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
For cases such as #1945 (comment). |
b0e0fda
to
ef2cd0e
Compare
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
Happy to answer any questions around this. |
I'm not sure we really need this. We've handled feature transitions with simple boolean flags. |
Right, boolean flags surely are a possible solution. However, my inclination towards replacing them with feature gates was motivated by a couple of observations.
|
That being said, if you think we are better off without these, PLMK and I'll close this. |
@SuperQ @discordianfish I'd be happy to add this to the agenda and pitch it in the call next-to-next week if that sounds good (or have an async discussion here if that works). |
Allow APIs to be gated conditionally.
Feature gates can be enforced by default, or overridden by the user. The latter takes priority if both cases conflict. Feature gates can be enabled, or disabled, and thus have two custom states. Note that the default state for a feature gate is
nil
, allowing us to distinguish if a feature gate is levied, raised, or not set.Signed-off-by: Pranshu Srivastava rexagod@gmail.com