Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve short sha #93

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Improve short sha #93

merged 4 commits into from
Oct 9, 2024
+368 −77

Conversation

janisozaur
Copy link
Contributor

No description provided.

@janisozaur
Fix fetchTotalCommit query and response
8f4c958
@janisozaur
Improve short-sha to better match git outputs
be9c45c 
This is a naive implementation that simply counts commits for given SHA.

Git actually counts all the objects in repository, so a better
approximation would at least use the repo's default branch instead of
current SHA, but I don't expect this action to be used on old commits
much.

There's still no checking if provided short-sha is unique or not.
@janisozaur
Fix sample output
a60cdfd
@janisozaur
Copy link
Contributor Author

Sorry, I've got no clue why Build / build and Build / compile fail anymore - I've fixed all the linting and formatting errors in submitted code already.

@janisozaur janisozaur mentioned this pull request Oct 1, 2024
Merged
@proudust proudust self-requested a review October 3, 2024 13:12
proudust
proudust requested changes Oct 3, 2024
View reviewed changes
Copy link
Owner

@proudust proudust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, and sorry for the late reply!
Before merging, could you run deno task build to update dist/actions.js and dist/cli.js, and then commit those changes, which should make the Build / build action pass.

@janisozaur
Copy link
Contributor Author

The Build / build is fixed now, but Build / compile still fails due to error when writing temp file.

@proudust
Copy link
Owner

proudust commented Oct 9, 2024

I’m not sure why the Build / compile is failing, but it works locally, so I think it’s probably fine. I’ll go ahead and merge. Thanks!

@proudust proudust merged commit 22205f9 into proudust:master Oct 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@proudust proudust proudust approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janisozaur @proudust