Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload z3 built by vcpkg as release assets in CI. Maybe test whether it works in CI later. #264

Draft
wants to merge 63 commits into
base: master
Choose a base branch
from

Conversation

TheVeryDarkness
Copy link
Contributor

The release name 0.12.2 is in env.Z3_VERSION and may be changed to z3-0.12.2 if expected.

Uploaded files in my fork is in 0.12.2.

I didn't attach a SHA256 or other validation information, and this may be added in the future.

And I may also add some codes to let z3-sys download and test uploaded archive. But archive for Windows is just too big, can we cache downloaded archive globally? Or add an env var that points to the archive?

Use vcpkg-rs to manage z3 instead. A non-default feature vcpkg is added.

However, vcpkg-rs does not support wasm32 target currently. I created a pull request there at mcgoo/vcpkg-rs#53
Make emscripten visible to wasm32-unknown-unknown if emscripten is installed.
Z3_HEADER_VAR will disappear when the feature vcpkg is enabled.
Use is_err instead of pattern matching.
Added missing cargo:rerun-if-changed for header.
So that rust can continue to build.
By this, we can check whether the toolchain matches the vcpkg triplet.
@TheVeryDarkness TheVeryDarkness changed the title Upload z3 built by vcpkg as release assets in CI. Maybe test it in CI later. Upload z3 built by vcpkg as release assets in CI. Maybe test whether it works in CI later. Oct 29, 2023
@TheVeryDarkness
Copy link
Contributor Author

TheVeryDarkness commented Oct 29, 2023

The test failed because there is no such release 0.12.2 here and it doesn't have write access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant