Merge pull request #468 from psteinroe/fix/swr-revalidate

fix: use only `mutate(key)` for revalidation
psteinroe · Jul 12, 2024 · 1d2d9eb · 1d2d9eb
2 parents 50c35fb + 2874096
commit 1d2d9eb
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/real-pants-stare.md b/.changeset/real-pants-stare.md
@@ -0,0 +1,5 @@
+---
+"@supabase-cache-helpers/postgrest-swr": patch
+---
+
+fix: revalidation flicker due to undefined data passed to mutate
diff --git a/packages/postgrest-swr/src/cache/use-delete-item.ts b/packages/postgrest-swr/src/cache/use-delete-item.ts
@@ -32,7 +32,7 @@ export function useDeleteItem<Type extends Record<string, unknown>>(
         cacheKeys: getMutableKeys(Array.from(cache.keys())),
         getPostgrestFilter,
         revalidate: (key) => {
-          mutate(key, null, { ...opts, revalidate: true });
+          mutate(key);
         },
         mutate: (key, data) => {
           mutate(key, data, { ...opts, revalidate: opts?.revalidate ?? false });

diff --git a/packages/postgrest-swr/src/cache/use-mutate-item.ts b/packages/postgrest-swr/src/cache/use-mutate-item.ts
@@ -34,7 +34,7 @@ export function useMutateItem<Type extends Record<string, unknown>>(
         cacheKeys: getMutableKeys(Array.from(cache.keys())),
         getPostgrestFilter,
         revalidate: (key) => {
-          mutate(key, null, { ...opts, revalidate: true });
+          mutate(key);
         },
         mutate: (key, data) => {
           mutate(key, data, {

diff --git a/packages/postgrest-swr/src/cache/use-upsert-item.ts b/packages/postgrest-swr/src/cache/use-upsert-item.ts
@@ -32,7 +32,7 @@ export function useUpsertItem<Type extends Record<string, unknown>>(
         cacheKeys: getMutableKeys(Array.from(cache.keys())),
         getPostgrestFilter,
         revalidate: (key) => {
-          mutate(key, null, { ...opts, revalidate: true });
+          mutate(key);
         },
         mutate: (key, data) => {
           mutate(key, data, {