fixup! Strip primary keys from the update payload

packages/postgrest-core/src/update-fetcher.ts

@@ -45,17 +45,18 @@ export const buildUpdateFetcher =
   async (
     input: Partial<T['Row']>,
   ): Promise<MutationFetcherResponse<R> | null> => {
-    const payload = { ...input };
+    const payload = stripPrimaryKeys
+      ? primaryKeys.reduce<typeof Input>((acc, key) => {
+        delete acc[key]
+        return acc
+      }, { ...input })
+      : input
     let filterBuilder = qb.update(payload as any, opts); // todo fix type;
     for (const key of primaryKeys) {
       const value = input[key];
       if (!value)
         throw new Error(`Missing value for primary key ${String(key)}`);
       filterBuilder = filterBuilder.eq(key as string, value);
-
-      if (stripPrimaryKeys) {
-        payload[key] = undefined;
-      }
     }
 
     const query = buildNormalizedQuery<Q>(opts);

packages/postgrest-core/tests/update-fetcher.spec.ts

@@ -1,5 +1,5 @@
 import { type SupabaseClient, createClient } from '@supabase/supabase-js';
-import { beforeAll, describe, expect, it } from 'vitest';
+import { beforeAll, describe, expect, it, vi } from 'vitest';
 
 import type { Database } from './database.types';
 import './utils';
@@ -41,20 +41,55 @@ describe('update', () => {
   });
 
   it('should update entity by primary keys', async () => {
+    const qb = client.from('contact');
+    const updateSpy = vi.spyOn(qb, 'update');
+    const username = `${testRunPrefix}-username-2`;
     const updatedContact = await buildUpdateFetcher(
-      client.from('contact'),
+      qb,
+      ['id'],
+      { stripPrimaryKeys: false, queriesForTable: () => [] },
+    )({
+      id: contact?.id,
+      username,
+    });
+    expect(updatedContact).toEqual({
+      normalizedData: {
+        id: expect.anything(),
+        username,
+      },
+    });
+    expect(updateSpy).toHaveBeenCalledWith({
+      id: expect.anything(),
+      username,
+    }, expect.anything());
+    const { data } = await client
+      .from('contact')
+      .select('*')
+      .eq('id', contact?.id ?? '')
+      .throwOnError()
+      .maybeSingle();
+    expect(data?.username).toEqual(`${testRunPrefix}-username-2`);
+  });
+
+  it('should update entity by primary keys excluding primary keys in payload', async () => {
+    const qb = client.from('contact');
+    const updateSpy = vi.spyOn(qb, 'update');
+    const username = `${testRunPrefix}-username-2`;
+    const updatedContact = await buildUpdateFetcher(
+      qb,
       ['id'],
       { queriesForTable: () => [] },
     )({
       id: contact?.id,
-      username: `${testRunPrefix}-username-2`,
+      username,
     });
     expect(updatedContact).toEqual({
       normalizedData: {
         id: expect.anything(),
-        username: `${testRunPrefix}-username-2`,
+        username,
       },
     });
+    expect(updateSpy).toHaveBeenCalledWith({ username }, expect.anything());
     const { data } = await client
       .from('contact')
       .select('*')