Use dataset.didNotAcceptTouch and getAllDivsUnderCoordinate in touch propagation #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…propagation This new approach cleanly cycles through candidate touch elements without style modification (setting display: none). This prevents a potential flash of elements hiding/unhiding themselves during the touch propagation cycle.
|
Speak of the devil, as I made this PR the weird bug I encountered at the very start of this rewrite came back so I'm marking this as a draft until I get more time to work on it |
Sounds good. I think I tried improving this in the past and also ran into bugs. Would be a great improvement if we ensure it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new approach cleanly cycles through candidate touch elements
without style modification (setting display: none). This prevents a
potential flash of elements hiding/unhiding themselves during the touch
propagation cycle.
Very high possibility for subtle bugs considering how fundamental this code is