Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to the documentation #553

Merged
merged 37 commits into from
Aug 29, 2024
Merged

Edits to the documentation #553

merged 37 commits into from
Aug 29, 2024

Conversation

PadowYT2
Copy link
Contributor

@PadowYT2 PadowYT2 commented Oct 17, 2023

Changes in this PR

  • Update supported PHP ranges to 8.1 - 8.3
  • Updated recommended/default PHP version to 8.3
  • Replaced (unsupported) CentOS with RHEL / Rocky Linux / AlmaLinux
  • Added some missing comments to web server configs
  • Updated footer copyright text
  • Swaps back to nodesources install scripts as these are now supported again
  • Adds Ubuntu 24.04 to the list of supported OSes
  • Minor formatting changes in web server configs
  • Minor wording and formatting changes

@PadowYT2 PadowYT2 requested a review from Boy132 October 19, 2023 19:00
@rowansc1
Copy link
Contributor

@PadowYT2 - Is this still something you want to merge eventually? Although it's been like 8 months lol

@PadowYT2
Copy link
Contributor Author

@PadowYT2 - Is this still something you want to merge eventually? Although it's been like 8 months lol

Sorry, but still waiting on the opinion on the original comment

@danny6167
Copy link
Member

For those playing along at home, I've been pushing builds of this to CF pages as I go along.
https://pr-553.ptero-doc-preview.pages.dev/

@PadowYT2
Copy link
Contributor Author

Didn't realize you are pushing your changes to this PR, I guess thanks. Also, why PHP 8.3 and not 8.2?

@danny6167
Copy link
Member

We wanted to get this PR finished and merged, but it touched so many different files we didn't want to work on other PRs for the other stuff and risk having to deal with the merge conflicts afterwards. We're happy to close this and open a different PR if you would prefer.

PHP 8.3 is fully released and compatible with Pterodactyl. I didn't see any reason to target 8.2 when it's only in active support for another 5 months.

@danny6167 danny6167 mentioned this pull request Aug 7, 2024
@danny6167 danny6167 removed the request for review from Boy132 August 7, 2024 02:43
@rowansc1
Copy link
Contributor

I'm happy with this in its current state 👍 well done

Every systemctl command in the documentation has sudo before, why not this one ?
@danny6167 danny6167 marked this pull request as ready for review August 17, 2024 16:33
Copy link
Contributor

@rowansc1 rowansc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All happy with this! Just need Matt to approve and merge :)

Copy link
Contributor Author

@PadowYT2 PadowYT2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If PHP 8.3 is used by default, we don't need nginx-php8.1-*.conf

@rowansc1 rowansc1 self-requested a review August 19, 2024 19:25
Copy link
Contributor

@rowansc1 rowansc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. I like the small changes here. I don't think the table changes were strictly needed, but definitely makes the markdown easier to read.

Should be good to go when matt reviews it. Thanks for coming back to it after so long @PadowYT2!

@matthewpi matthewpi merged commit 369fa55 into pterodactyl:master Aug 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants