Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

done with the update #210

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

done with the update #210

wants to merge 2 commits into from

Conversation

ananya218
Copy link

No description provided.

@welcome
Copy link

welcome bot commented Oct 18, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

VladimirMikulic
VladimirMikulic reviewed Jan 10, 2020
View reviewed changes
Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ananya218 could you please rebase this branch and explain to me what issue you were fixing?
Thanks.

@LeoDog896
Copy link

@ananya218 It would be very helpful if you can submit more detail about your pull request. From what I see, its moving JSON to the .gitignore, which doesn't seem too helpful, since .gitignore doesn't support JSON and this project uses Bower -- which you removed the configuration for. If you have an explanation, that would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirMikulic VladimirMikulic VladimirMikulic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ananya218 @LeoDog896 @VladimirMikulic