Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minecraft-autoplug Template #241

Merged
merged 8 commits into from
Feb 21, 2024
Merged

Add minecraft-autoplug Template #241

merged 8 commits into from
Feb 21, 2024

Conversation

Minionguyjpro
Copy link
Contributor

@Minionguyjpro Minionguyjpro commented Oct 17, 2023

This adds a template for the AutoPlug client, a client for Minecraft servers with additional features. It runs on top of the Minecraft server, hence the client will execute the Minecraft server Java instance. I've added some notes for things that should be changed to make it work, but when that's all done it will work perfectly.

@Minionguyjpro
Copy link
Contributor Author

Ohhhh I accidentally edited the purpur files. I will restore them.

@Minionguyjpro
Copy link
Contributor Author

Okay done, I fixed/restored it back as it was. Now all changes shall be correct.

@LordRalex
Copy link
Member

Can you please order the properties of the files the same?

Please refer to https://github.com/PufferPanel/templates/blob/v2.6/minecraft-vanilla/minecraft-vanilla.json for a desired ordering.

@Minionguyjpro
Copy link
Contributor Author

Can you please order the properties of the files the same?

Please refer to https://github.com/PufferPanel/templates/blob/v2.6/minecraft-vanilla/minecraft-vanilla.json for a desired ordering.

The build and version flags don't apply to this, as the client does only offer the latest build at a time and it isn't the server software itself, just the client that can run it.

@LordRalex
Copy link
Member

Can you please order the properties of the files the same?
Please refer to https://github.com/PufferPanel/templates/blob/v2.6/minecraft-vanilla/minecraft-vanilla.json for a desired ordering.

The build and version flags don't apply to this, as the client does only offer the latest build at a time and it isn't the server software itself, just the client that can run it.

Order as in, the data section is first, then the install section, then the run section, and so on. The specific variables are not what I meant.

@Minionguyjpro
Copy link
Contributor Author

Minionguyjpro commented Oct 20, 2023 via email

@Minionguyjpro
Copy link
Contributor Author

Can you please order the properties of the files the same?
Please refer to https://github.com/PufferPanel/templates/blob/v2.6/minecraft-vanilla/minecraft-vanilla.json for a desired ordering.

The build and version flags don't apply to this, as the client does only offer the latest build at a time and it isn't the server software itself, just the client that can run it.

Order as in, the data section is first, then the install section, then the run section, and so on. The specific variables are not what I meant.

Although, why does Purpur use this ordering instead?

@Minionguyjpro
Copy link
Contributor Author

@LordRalex Done! I fixed the ordering and it should be correct now.

@Minionguyjpro
Copy link
Contributor Author

@LordRalex I hope you'll be able to merge this soon.

@LordRalex LordRalex merged commit a42f64c into pufferpanel:v2.6 Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants