Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the terraria-tmodloader template #244

Open
wants to merge 4 commits into
base: v2.6
Choose a base branch
from

Conversation

Amatsu-Kami
Copy link

No description provided.

@Amatsu-Kami
Copy link
Author

fixes #234

@joelkoen
Copy link

joelkoen commented Sep 2, 2024

Pushing the install button again to update the server hangs. Should unzip automatically overwrite old files?

DAEMON  Downloading file https://github.com/tModLoader/tModLoader/releases/download/v2024.06.3.1/tModLoader.zip
DAEMON  Writing some data to file: EnableAllMods.sh
DAEMON  Writing some data to file: serverconfig.txt
DAEMON  Writing some data to file: enabled.json
DAEMON  Executing: unzip tModLoader.zip -d ./server
DAEMON  Starting process: unzip tModLoader.zip -d ./server
Archive:  tModLoader.zip
replace ./server/tModPorter/tModPorter.sh? [y]es, [n]o, [A]ll, [N]one, [r]ename: 

@Amatsu-Kami
Copy link
Author

Pushing the install button again to update the server hangs. Should unzip automatically overwrite old files?

DAEMON  Downloading file https://github.com/tModLoader/tModLoader/releases/download/v2024.06.3.1/tModLoader.zip
DAEMON  Writing some data to file: EnableAllMods.sh
DAEMON  Writing some data to file: serverconfig.txt
DAEMON  Writing some data to file: enabled.json
DAEMON  Executing: unzip tModLoader.zip -d ./server
DAEMON  Starting process: unzip tModLoader.zip -d ./server
Archive:  tModLoader.zip
replace ./server/tModPorter/tModPorter.sh? [y]es, [n]o, [A]ll, [N]one, [r]ename: 

I don't think it should be handled by the template, you just have to enter "A" in the command if you want to replace everything.

@joelkoen
Copy link

joelkoen commented Sep 7, 2024

This isn't the case, I tried doing that before but it doesn't actually forward it to the unzip command.

I think that the template should at least be changed so that repeated installs don't hang.

@Amatsu-Kami
Copy link
Author

Should be good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants