Skip to content

Commit

Permalink
[hardware] 🐛 Fix alu reduction race condition
Browse files Browse the repository at this point in the history
  • Loading branch information
mp-17 committed Aug 26, 2024
1 parent 1c88667 commit c98bcc0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hardware/src/lane/valu.sv
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@ module valu import ara_pkg::*; import rvv_pkg::*; import cf_math_pkg::idx_width;
if ((vinsn_queue_d.issue_cnt == '0) && !prevent_commit) begin
// INTRA_LANE_REDUCTION state needs the result queue
// Start the reduction only if the commit queue (so, the result queue, too) is empty
alu_state_d = is_reduction(vfu_operation_i.op) && (commit_cnt_q == '0) ? INTRA_LANE_REDUCTION : NO_REDUCTION;
alu_state_d = is_reduction(vfu_operation_i.op) && (vinsn_queue_d.commit_cnt == '0) ? INTRA_LANE_REDUCTION : NO_REDUCTION;
// The next will be the first operation of this instruction
// This information is useful for reduction operation
// Initialize reduction-related sequential elements
Expand Down

0 comments on commit c98bcc0

Please sign in to comment.