A 'repository' keyword to python_distribution module
#162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulp Python plugin supports setting up a distribution to track the latest RepositoryVersion of a Pulp Python repository.
mdellweg
reviewed
Jun 14, 2024
Comment on lines
-131
to
+150
| entity_plural="distribuions", | ||
| entity_plural="distributions", |
| repository_ctx = PulpPythonRepositoryContext( | ||
| module.pulp_ctx, entity={"name": repository_name} | ||
| ) | ||
| desired_attributes["repository"] = repository_ctx.pulp_href |
There was a problem hiding this comment.
Would you mind trying if this worked too?
Suggested change
| desired_attributes["repository"] = repository_ctx.pulp_href | |
| desired_attributes["repository"] = repository_ctx |
I think glue should be able to resolve that.
|
And for the CI to pass, you'd need to rerecord the fixtures for this module. |
|
I merged the change by hand... |
|
Thanks @mdellweg . I haven't been able to spend more time on this as I had other priorities. This PR is currently the last item on my TODO of today. Which I had hopes to reach this morning... but alas Pulp is giving me trouble with permissions in the container repository space so I have other things to tend to. Next time I'll reply back sooner to let you know I'll get to it when I can. My apologies. |
|
No problem. I just want to release soon and this looked like a good thing to wrap up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many Pulp plugins allow a distribution to track the latest RepositoryVersion of a repository. This PR adds support for that functionality to the
python_distributionmodule.This makes maintaining custom Python repositories easier by not having to retrieve and update the latest publication to distribute. The repository is immediately updated when a developer uploads an updated Python package to the repository. Decreasing the effort required, by Ansible and me, to squeeze my Pulp into shape. 😉
I hope everything is up to par, otherwise please point out or explain to me the areas I need to patch up and I will have a look at it as soon as I am able.