add pulp_timeout #164
add pulp_timeout #164
Conversation
plugins/doc_fragments/pulp.py
Outdated
| @@ -42,6 +42,11 @@ class ModuleDocFragment(object): | |||
| - It is recommended to use this once with the M(pulp.squeezer.status) module at the beginning of the playbook. | |||
| type: bool | |||
| default: false | |||
| pulp_timeout: | |||
| description: | |||
| - timeout value for connecting to pulp api | |||
There was a problem hiding this comment.
This is not what timeout does.
There was a problem hiding this comment.
time in seconds to wait for successful connection to pulp api - would that be a better description?
There was a problem hiding this comment.
No, you are trying to make this parameter available to the not yet rewritten modules:
https://github.com/pulp/squeezer/blob/develop/plugins/doc_fragments/pulp.py#L63
There was a problem hiding this comment.
I am not sure if I follow.
I suppose what you're saying is that you're rewriting modules to use pulp_glue which already has this timeout?
As far as I can see, at least the rpm related modules are still using this openapi.py and it lacks this setting, which causes me some issues that I described in #163.
Can you explain what I am supposed to do to get this merged?
There was a problem hiding this comment.
Yes, basically.
You should use the same name and the same description at the very least. So rewriting the modules eventually will not break this again.
|
I see the pipeline failed due to ansible removing support for python3.10 |
|
Nah, it would be better to fix the ci first. |
|
|
Please rebase this. |
|
Are we going to merge #166 first? |
|
I don't think, we need that anymore. I only adds more test combinations. And I am quite happy that we are down to 4 combinations, and still covering all supported ansible versions. |
maciej-markowski
force-pushed
the
feature/add-pulp-timeout
branch
from
015f7ae
to
02d87a9
Compare
#163
this PR adds pulp_timeout parameter.