Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pulumi-version-file to native providers #995

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Add pulumi-version-file to native providers #995

merged 4 commits into from
Jun 25, 2024

Conversation

corymhall
Copy link
Contributor

This adds the new pulumi-version-file support to native providers (except for google which does not have a .pulumi.version file)

@corymhall
Add pulumi-version-file to native providers
996d95e 
This adds the new `pulumi-version-file` support to native providers
(except for google which does not have a .pulumi.version file)
@corymhall corymhall marked this pull request as draft June 25, 2024 15:41
@corymhall corymhall marked this pull request as ready for review June 25, 2024 16:21
@corymhall corymhall requested a review from a team June 25, 2024 17:15
@corymhall corymhall self-assigned this Jun 25, 2024
danielrbradley
danielrbradley approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google Native is an odd case as we've also disabled pushing changes out to it. Perhaps we should consider just removing it from this tooling if it would allow us to simplify the config rather than keeping special cases for it.

@guineveresaenger guineveresaenger mentioned this pull request Jun 25, 2024
Merged
guineveresaenger added a commit that referenced this pull request Jun 25, 2024
@guineveresaenger
hotfix: run lint-actions.yml on all pull requests to master (#997)
c76c293 
#993 refactored the Required "Run actionlint and shellcheck" job,
limiting it to top-level `.github` paths.
This caused #995 and #996 to hang indefinitely.

This pull request re-enables this check to run on every pull request.
@corymhall corymhall merged commit 5cdb2bf into master Jun 25, 2024
6 checks passed
@corymhall corymhall deleted the corymhall/pulumi-version-file branch June 25, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielrbradley danielrbradley danielrbradley approved these changes

Assignees

@corymhall corymhall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corymhall @danielrbradley