Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Copilot position on Tutorials page #13009

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Fixes Copilot position on Tutorials page #13009

merged 3 commits into from
Oct 9, 2024

Conversation

foot
Copy link
Contributor

@foot foot commented Oct 2, 2024 •
edited
Loading

Proposed changes

  • Fixes Copilot position on the tutorials page
  • Introduces a config variable for the copilot basePath to support local development

@foot foot force-pushed the simon/copilot-fix-tutorials branch from a70715e to 7478610 Compare October 2, 2024 12:56
@pulumi-bot
Copy link
Collaborator

Your site preview for commit a70715e is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13009-a70715eb.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 7478610 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13009-74786104.s3-website.us-west-2.amazonaws.com.

@foot foot marked this pull request as ready for review October 3, 2024 15:16
@foot foot force-pushed the simon/copilot-fix-tutorials branch from 7478610 to 0135a1e Compare October 7, 2024 08:30
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 0135a1e is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13009-0135a1eb.s3-website.us-west-2.amazonaws.com.

sean1588
sean1588 previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@sean1588 sean1588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to just approve this. From a code glance it all seems fine to me. If this is deployed on your dev stack, then would be great to check this out. But since this is still behind the feature flag, then I think its safe enough to go ahead and ship.

theme/src/scss/_copilot.scss Outdated Show resolved Hide resolved
@sean1588 sean1588 self-requested a review October 8, 2024 21:16
@sean1588 sean1588 dismissed their stale review October 8, 2024 21:19

see comment

@foot foot force-pushed the simon/copilot-fix-tutorials branch from 0135a1e to b715913 Compare October 9, 2024 13:50
@pulumi-bot
Copy link
Collaborator

Your site preview for commit b715913 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13009-b715913e.s3-website.us-west-2.amazonaws.com.

sean1588
sean1588 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@sean1588 sean1588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @foot !! LGTM 🚢

@foot foot merged commit d0867d3 into master Oct 9, 2024
8 checks passed
@foot foot deleted the simon/copilot-fix-tutorials branch October 9, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean1588 sean1588 sean1588 approved these changes

@cnunciato cnunciato Awaiting requested review from cnunciato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foot @pulumi-bot @sean1588