Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Creating Resources on Google Cloud Tutorial #13050

Merged
merged 20 commits into from
Oct 9, 2024
Merged

Add Creating Resources on Google Cloud Tutorial #13050

merged 20 commits into from
Oct 9, 2024

Conversation

toriancrane
Copy link
Contributor

@toriancrane toriancrane commented Oct 7, 2024 •
edited
Loading

Proposed changes

This PR adds the tutorial content for Creating Resources on Google Cloud tutorial. It also does the following:

  • Removes the Pulumi Fundamentals Learn series
  • Removes the Building with Pulumi Learn series
  • Adds the aliases for the removed Learn content

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 92615e1 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13050-92615e11.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 78cdc85 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13050-78cdc85a.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 6bf30b7 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13050-6bf30b7d.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 39b0010 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13050-39b0010d.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit a343bf1 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13050-a343bf1e.s3-website.us-west-2.amazonaws.com.

@toriancrane toriancrane marked this pull request as ready for review October 8, 2024 08:15
@toriancrane toriancrane requested a review from a team as a code owner October 8, 2024 08:15
thoward
thoward approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@thoward thoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small change to the intro paragraph, the GCP tutorial looks ready to go.

It's probably just my lack of context on the plan here, but why are we removing Pulumi Fundamentals/Building w/ Pulumi content? Also, seems like the Azure tutorial is copied here from #13024. I didn't check those files for parity, so there's a potential for merge conflict if they differ at all from the other PR.

content/tutorials/creating-resources-gcp/index.md Outdated Show resolved Hide resolved
@toriancrane toriancrane enabled auto-merge (squash) October 9, 2024 09:37
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 65dd2a9 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13050-65dd2a9f.s3-website.us-west-2.amazonaws.com.

@toriancrane toriancrane merged commit 356e63c into master Oct 9, 2024
6 checks passed
@toriancrane toriancrane deleted the torian/create-resources-gcp branch October 9, 2024 10:01
cnunciato added a commit that referenced this pull request Oct 9, 2024
@cnunciato
Revert "Add Creating Resources on Google Cloud Tutorial (#13050)"
ed9df5b 
This reverts commit 356e63c.
@cnunciato cnunciato mentioned this pull request Oct 9, 2024
Merged
cnunciato added a commit that referenced this pull request Oct 9, 2024
@cnunciato
Revert "Add Creating Resources on Google Cloud Tutorial (#13050)" (#1…
d81ab6f 
…3089)

This reverts commit 356e63c.
@toriancrane toriancrane restored the torian/create-resources-gcp branch October 15, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoward thoward thoward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toriancrane @pulumi-bot @thoward