Skip to content

Commit

Permalink
Remove gotestfmt as it's unreliable (#3596)
Browse files Browse the repository at this point in the history
Following ci-mgmt where it [was already
removed](pulumi/ci-mgmt#1069).
  • Loading branch information
thomas11 authored Sep 27, 2024
1 parent 0967dd9 commit 8e65c18
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 16 deletions.
6 changes: 0 additions & 6 deletions .github/actions/test-setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,3 @@ runs:
- name: Install dependencies
run: make install_${{ inputs.language}}_sdk
shell: bash

- name: Install gotestfmt
uses: jaxxstorm/action-install-gh-release@v1.11.0
with:
tag: v2.5.0
repo: GoTestTools/gotestfmt
14 changes: 4 additions & 10 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,13 @@ jobs:
ARM_CLIENT_CERTIFICATE_PATH_FOR_TEST: "${{ runner.temp }}/azure-client-certificate.pfx"
run: |
set -euo pipefail
cd examples && go test -v -json -cover -timeout 2h -tags=${{ matrix.language }} -skip TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log | gotestfmt
cd examples && go test -cover -timeout 2h -tags=${{ matrix.language }} -skip TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log
- name: Run short tests
if: inputs.short_test
run: |
set -euo pipefail
cd examples && go test -v -json -cover -timeout 15m -short -tags=${{ matrix.language }} -skip TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log | gotestfmt
cd examples && go test -cover -timeout 15m -short -tags=${{ matrix.language }} -skip TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log
test_examples:
needs: build_sdks
Expand Down Expand Up @@ -263,7 +263,7 @@ jobs:
cd examples && \
go mod edit -replace github.com/pulumi/examples/misc/test=../p-examples/misc/test/ && \
go mod tidy && \
go test -v -json -cover -timeout 2h -tags=${{ matrix.language }} -run TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log | gotestfmt
go test -cover -timeout 2h -tags=${{ matrix.language }} -run TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log
test_provider:
runs-on: ubuntu-latest
Expand All @@ -281,12 +281,6 @@ jobs:
with:
skip_dotnet_and_java: "true"

- name: Install gotestfmt
uses: jaxxstorm/action-install-gh-release@v1.11.0
with:
tag: v2.5.0
repo: GoTestTools/gotestfmt

- run: make ensure

- name: Prerequisites artifact restore
Expand All @@ -302,7 +296,7 @@ jobs:
- name: Test Provider Library
run: |
set -euo pipefail
cd provider && go test -v -json -coverprofile="coverage.txt" -coverpkg=./... -timeout 1h -parallel 16 ./... 2>&1 | tee /tmp/gotest.log | gotestfmt
cd provider && go test -coverprofile="coverage.txt" -coverpkg=./... -timeout 1h -parallel 16 ./... 2>&1 | tee /tmp/gotest.log
- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v4
Expand Down

0 comments on commit 8e65c18

Please sign in to comment.