Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGA-9575 Adding SatoriCyber Pulumi provider #4438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ron-ts
Copy link

@ron-ts ron-ts commented May 2, 2024

Description

Adding a new package?

If this pull request adds a new package:

  • The package's schema URL is correct.
  • The package metadata file, if present, contains:
    • a supported category (one of Cloud, Infrastructure, Network, Database, Monitoring, or Utility).
    • a description that explains what the package does.
    • a valid logo URL that points to a PNG whose dimensions conform to the others in this repo (e.g., 100x100).
    • a version number prefixed with v that corresponds with a valid GitHub release.
  • The package repo contains an Overview doc (/docs/_index.md) that includes:
    • a brief explanation of what the package is and what it does.
    • at least one representative example in all supported languages.
    • a front-matter property for the layout set to package.
  • The package repo contains an Installation and Configuration doc (/docs/installation-configuration.md) that includes:
    • links to SDKs in all supported languages.
    • a copyable command for installing the resource plugin if necessary.
    • an example of configuring the provider with pulumi config set.
    • an example of configuring the provider with environment variables.
  • A CODEOWNER has reviewed the PR.
  • A member of the @pulumi/docs team has reviewed all documentation.

@sean1588
Copy link
Member

sean1588 commented May 3, 2024

Hi @ron-ts , thanks for your contribution!

A couple of things that need some adjustments here before we can get this through:

  1. There are a couple ~ at the start of the installation guide. We should remove these. Only --- is needed.
  2. We need to set the layout property to package in both the overview page and install page. I'm guessing you forked this from one of our boilerplates and it had those properties set, we probably need to get the boilerplate updated, sorry about that.

@ron-ts
Copy link
Author

ron-ts commented May 5, 2024

Hey @sean1588

Comments fixed 😃
you can check it out here

Thanks for the quick review!

@sean1588
Copy link
Member

sean1588 commented May 8, 2024

The provider binaries need to be included in the release artifacts. I chatted with @ron-ts about this in community slack.

@ron-ts
Copy link
Author

ron-ts commented May 21, 2024

Hey guys.

We've added a task to include the binaries.
Hope to get to it soon.

Will update here and in slack once it will be done.

@ringods
Copy link
Member

ringods commented Jun 20, 2024

@ron-ts when will you make a new release including the plugin binaries in the Github Release?

@ringods
Copy link
Member

ringods commented Jul 16, 2024

@ron-ts checking in again. The last thing missing is a Github Release containing the provider binaries. Any idea when these will/can be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants