Simplify interface and add type hints #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattHag
force-pushed
the
simplify_interface
branch
5 times, most recently
from
1714748
to
b09543d
Compare
This module shouldn't be necessary on the long run. Remove pieces from it whenever possible.
Enforce a total coverage of 40% of the code. Related pwr-Solaar#1097
Create coverage.xml, upload it to GitHub CI and visualize with codecov. Setup instruction: - Install codecov for project https://github.com/settings/installations/55029514 - Add CODECOV_TOKEN in the GitHub CI project secrets Related pwr-Solaar#1097
Introduce unit tests. Related pwr-Solaar#2273
Introduce unit tests. Related pwr-Solaar#2273
- Remove comments with unused receivers - Simplify receiver hardcoded info
Add test for it.
MattHag
force-pushed
the
simplify_interface
branch
from
b09543d
to
3651d83
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2608 +/- ##
=========================================
Coverage ? 47.92%
=========================================
Files ? 52
Lines ? 14337
Branches ? 2817
=========================================
Hits ? 6871
Misses ? 7080
Partials ? 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pfps
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.