Test diversion rules #2620
Closed
Test diversion rules #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module shouldn't be necessary on the long run. Remove pieces from it whenever possible.
Enforce a total coverage of 40% of the code. Related pwr-Solaar#1097
Create coverage.xml, upload it to GitHub CI and visualize with codecov. Setup instruction: - Install codecov for project https://github.com/settings/installations/55029514 - Add CODECOV_TOKEN in the GitHub CI project secrets Related pwr-Solaar#1097
Introduce unit tests. Related pwr-Solaar#2273
Introduce unit tests. Related pwr-Solaar#2273
- Remove comments with unused receivers - Simplify receiver hardcoded info
Add test for it.
Name the key symbol mapping different than the module itself.
Fix typo in package name.
Linux uses udev, other platforms use the cross-platform hidapi implementation. Remove implicit loading of hidapi in hidapi/__init__.py.
Split model and view, and enable view mocks for unit tests without GDK.
Clean up, type hint and tests base_usb and related modules.
Avoid the need for hidapi imports and add them to the base API module.
Avoid direct access to hidapi and use the base module as low-level API instead. This change replaces the remaining calls to find_paired_node and find_paired_node_wpid by exposing them via base module.
With this test all receiver tests are macOS compatible again. The low level interface supports passing a fake API for unit tests.
A module level function is sufficient, no wrapper needed.
Avoids spelling mistakes and helps readability.
Warnings found by automatic code inspection and partially tackled - Drop distuitls inf favour of setuptools - Replace deprecated pyudev.Device.from_device_number - Remove unnecessary brackets - Avoid access to private variables etc. - Shadows built-in name - Line length >120 characters - Not a module level variable - Simplify clause and more
Improve type hints and names.
Make internal functions private.
Import gi solely for type checking.
Reduce complexity of diversion dialog.
Fix diverged signature of RuleComponentUI subclasses.
MattHag
force-pushed
the
test_diversion_rules
branch
from
8c502bd
to
3268017
Compare
Test labels of each rule condition UI.
MattHag
force-pushed
the
test_diversion_rules
branch
from
3268017
to
bb23443
Compare
|
There is a failing test here. Can you find out what is going wrong? |
|
I was just getting around to looking at this PR and I found a problem with Solaar on my Bluetooth keyboard. I'll have to look at this first. |
|
There's one with Bolt as well, but that issue already occurred in the master and shouldn't be related to these changes. |
The gtk/gi/low level dependencies with hatdware access. The modules in logitech_receiver and solar packages need to get more independent for these new tests to work as unit tests. You can check out the latest pull request that's verified. This one should not be merged without further work. |
|
So should this PR be marked as work in progress |
|
Replaced by #2626 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.