Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: augment pairing message for devices with multiple channels #2625

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

pfps
Copy link
Collaborator

@pfps pfps commented Oct 8, 2024

Fixes #2622

@pfps pfps merged commit 4aada31 into pwr-Solaar:master Oct 8, 2024
5 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@128ec43). Learn more about missing BASE report.

Files with missing lines Patch % Lines
lib/solaar/cli/pair.py 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2625   +/-   ##
=========================================
  Coverage          ?   47.93%           
=========================================
  Files             ?       52           
  Lines             ?    14343           
  Branches          ?     2817           
=========================================
  Hits              ?     6875           
  Misses            ?     7082           
  Partials          ?      386           
Flag Coverage Δ
unittests 47.89% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: the app itself (and other documentation?) has nothing on channels; applies (only?) to Logitech
2 participants