Skip to content

Commit

Permalink
Fix README
Browse files Browse the repository at this point in the history
  • Loading branch information
ewjoachim authored and kieferro committed Sep 13, 2023
1 parent 5f187f8 commit 9b4db25
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ jobs:
### Basic usage without external contributors

If you don't expect external contributors, you don't need all the shenanigans
with the artifacts and the 2nd workflow. This is likely to be the most straightfoward
with the artifacts and the 2nd workflow. This is likely to be the most straightforward
way to configure it for private repositories. It might look like this:

```yaml
Expand Down Expand Up @@ -198,7 +198,6 @@ jobs:
run: make test # This is the part where you put your own test command

- name: Coverage comment
id: coverage_comment
uses: py-cov-action/python-coverage-comment-action@v3
with:
GITHUB_TOKEN: ${{ github.token }}
Expand Down Expand Up @@ -430,15 +429,15 @@ jobs:
run: make -C project_2 test
- name: Coverage comment (project 1)
id: coverage_comment
id: coverage_comment_1
uses: py-cov-action/python-coverage-comment-action@v3
with:
COVERAGE_PATH: project_1
SUBPROJECT_ID: project-1
GITHUB_TOKEN: ${{ github.token }}
- name: Coverage comment (project 2)
id: coverage_comment
id: coverage_comment_2
uses: py-cov-action/python-coverage-comment-action@v3
with:
COVERAGE_PATH: project_2/src
Expand All @@ -447,7 +446,7 @@ jobs:
- name: Store Pull Request comment to be posted
uses: actions/upload-artifact@v3
if: steps.coverage_comment.outputs.COMMENT_FILE_WRITTEN == 'true'
if: steps.coverage_comment_1.outputs.COMMENT_FILE_WRITTEN == 'true' || steps.coverage_comment_2.outputs.COMMENT_FILE_WRITTEN == 'true'
with:
name: python-coverage-comment-action
# Note the star
Expand Down

0 comments on commit 9b4db25

Please sign in to comment.