feat: marker as argument #180
Conversation
ArzelaAscoIi
commented
May 31, 2023
•
ArzelaAscoIi
commented
- added the "marker" argument to enable multiple comments for multiple services in a single repository
- adjusted tests for a custom marker
|
End-to-end public repo |
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)coverage_comment/template.py
coverage_comment/settings.py
|
There was a problem hiding this comment.
Thank you for your PR. Looks good to me so far.
An addition to the README would still be nice so that the docs contain the new parameter. I guess this is then also to be used in conjunction with COVERAGE_DATA_BRANCH so that coverage data can be collected for several applications in one repo? This could perhaps also be written specifically in the README.
| @@ -45,6 +43,7 @@ def get_comment_markdown( | |||
| previous_coverage_rate: decimal.Decimal | None, | |||
| base_template: str, | |||
| custom_template: str | None = None, | |||
| marker: str = "<!-- This comment was produced by python-coverage-comment-action -->", | |||
There was a problem hiding this comment.
I guess this might be a mandatory parameter, to avoid hardcoding the default value in multiple places more than necessary
|
Thanks for the review! I will adjust the docs + and rework the commits next week :) |
|
Interestingly, I just realized that I did a branch 4 months ago that I never finished, which did the same thing. Here's the work I did, might inspire you :) https://github.com/py-cov-action/python-coverage-comment-action/tree/monorepo |
|
(Just so you know, I've finally openned the PR #213 based on the branch I mentionned above. It does things a bit differently, using a single setting to take care of all monorepo issues) |
|
Ahh for not getting back to it. So let's close this one and follow your approach :) |
