Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SUBPROJECT_ID setting #213

Merged
merged 15 commits into from
Aug 15, 2023
Merged

Add SUBPROJECT_ID setting #213

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
acd3e09
Add SUBPROJECT_ID setting
ewjoachim Aug 3, 2023
4010b5f
Use SUBPROJECT_ID
ewjoachim Jul 23, 2023
9a95e43
Unrelated doc improvements
ewjoachim Jul 23, 2023
1b5fdcf
Add subproject_id in comment
ewjoachim Jul 28, 2023
118e63e
Add missing return type
ewjoachim Aug 5, 2023
b799713
Add an additional check in e2e
ewjoachim Aug 5, 2023
3d2d91c
Fix missing text in e2e assertion
kieferro Aug 6, 2023
c977633
Upload all generated pull request comments in e2e tests
kieferro Aug 6, 2023
8b83084
Avoid using `None` as subproject_id and use `null` instead
kieferro Aug 6, 2023
76b0db9
Update coverage_comment/settings.py
ewjoachim Aug 7, 2023
70693c8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 7, 2023
c441292
Update action.yml
ewjoachim Aug 7, 2023
a00d656
Display subproject_id in readme & log
ewjoachim Aug 10, 2023
d176344
Slightly change the fix for making subproject_id a json string
ewjoachim Aug 10, 2023
07b9b64
Fix README
ewjoachim Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/end_to_end/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ def code_path(request):
@pytest.fixture
def subproject_id(request):
mark = request.node.get_closest_marker("subproject_id")
return mark.args[0] if mark else None
kieferro marked this conversation as resolved.
Show resolved Hide resolved
return mark.args[0] if mark else "null"


@pytest.fixture
Expand Down
Loading