-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add summary comment #444
add summary comment #444
Conversation
Admin commands cheatsheet:
|
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
Can you look at existing tests and tell me if it's easy to add a new one for this case ? |
From my reading of the tests, this one seems to confirm that this functionality should work. It seems that mocks are rarely used, so I'm not sure how else to verify that it is called with None for max_files. If you have a place in mind you would like me to add a test please let me know and I will gladly do my best. python-coverage-comment-action/tests/unit/test_template.py Lines 327 to 357 in fafc0ae
|
(Ah sorry, missed you message). I agree with you, adding a test there will probably mean more mocks, and limited value. Let's go ! |
Released in https://github.com/py-cov-action/python-coverage-comment-action/releases/tag/v3.26 :) Thank you very much for your contribution ! |
Fix for #442 to create a separate summary comment from the truncated PR comment