Add tests for our CLI #877
Conversation
currently makes use of demo.mcstatus.io as a test server, but it would be good to run a local instance maybe. also adds output tests for --help, allowing this to be used in documentation.
|
|
||
| s = s.strip() | ||
|
|
||
| # drop lines which end in ":". these argparse section headings vary between python versions. |
There was a problem hiding this comment.
Could you elaborate on this? How do these differ across python versions? Would it be possible to instead add a sys.version_info conditional and only perform 1 replace for the older form to normalize into the newer one?
There was a problem hiding this comment.
Switching on version is frowned upon and, for such a trivial change that's probably not explicitly documented, would require bisecting the versions.
You could maintain a manual map of replacements, I think these are very few in number. They only concern the "positional arguments", "required arguments", etc section headings.
There was a problem hiding this comment.
I see, okay then, doing that does seem fairly annoying, so let's not go there. But it might be worth explaining this a bit more in that comment for people looking at the code.
There was a problem hiding this comment.
I don't really know how to clarify it more, is what is done in c01c7ca enough?
In 3.12 `socket.timeout` is an alias to `TimeoutError`, but in previous versions they are different.
This is the continuation for #865 (AFAIK I don't have push access to that branch).