Add token and pin initialization #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxwolfe
force-pushed
the
feature/initialize-tokens
branch
from
69ae329
to
a261695
Compare
|
I wrote this casually for personal use and am not super familiar with extending Python with C, so please don't hesitate to comment if there are better ways to do certain things. |
maxwolfe
force-pushed
the
feature/initialize-tokens
branch
from
a261695
to
69d938a
Compare
Added as Token.init_token and Session.init_pin
maxwolfe
force-pushed
the
feature/initialize-tokens
branch
from
69d938a
to
287dd87
Compare
danni
reviewed
Jan 17, 2022
| assertRV(_funclist.C_InitToken(slot_id, pin_data, pin_length, | ||
| label)) | ||
|
|
||
| return True |
There was a problem hiding this comment.
Rather than returning True/False out of this function, it's probably better to return None or raise ArgumentsBad. That means you can try/except/finally your codepath.
| tlabel = token_label.encode('utf-8') | ||
|
|
||
| if pin and tlabel: | ||
| pin_data = pin |
There was a problem hiding this comment.
I don't think you need to reassign these?
There was a problem hiding this comment.
Oh, I suppose you do for nogil, NM
| pin = user_pin.encode('utf-8') | ||
|
|
||
| if pin: | ||
| pin_data = pin |
There was a problem hiding this comment.
I don't think you need to reassign this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding implementations and tests for C_InitToken and C_InitPIN
Happens to also solve: #6