Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bot] Update dependencies #1625

Merged
merged 1 commit into from
Sep 26, 2023
Merged

[Bot] Update dependencies #1625

merged 1 commit into from
Sep 26, 2023

Conversation

cibuildwheel-bot[bot]
Copy link
Contributor

Update the versions of our dependencies.

PR generated by "Update dependencies" workflow.

Copy link
Member

@mayeut mayeut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bumps CPython 3.12 to rc3, probably worth a new release of cibuildwheel.

Tests failures are related to credit exhaustion on Cirrus CI

@henryiii
Copy link
Contributor

henryiii commented Sep 25, 2023

(When it’s ready) Patch release, please! :) The last release was a minor release, causing all the vX.Y pins to get bumped by dependabot, but it didn't add or remove Python versions and didn't change anything that used to work, making it feel like a patch release.

Arguably the problem really is that we should have made major releases when platforms change, and we’d be at version 30 or something.

@EwoutH
Copy link
Contributor

EwoutH commented Sep 26, 2023

Could this be merged and a new release be tagged? It would be nice to build wheels with rc3.

@joerick
Copy link
Contributor

joerick commented Sep 26, 2023

(When it’s ready) Patch release, please! :) The last release was a minor release, causing all the vX.Y pins to get bumped by dependabot, but it didn't add or remove Python versions and didn't change anything that used to work, making it feel like a patch release.

v2.16.0 added new features, so it gets a minor release, that's always been my rule. I know what you mean, though, the dependabot updates are noisy. Maybe there's something we can do to better support that. I actually feel inclined to make a vX moving tag too, some of my projects don't really care much about repeatability.

@joerick joerick merged commit 9deb1b6 into main Sep 26, 2023
13 of 18 checks passed
@joerick joerick deleted the update-dependencies-pr branch September 26, 2023 08:44
@henryiii
Copy link
Contributor

henryiii commented Oct 2, 2023

If someone wants no pinning, they can just use pipx run cibuildwheel. The point of the action is the pinning. The thing that does break most users on updates is adding new Python versions (3.12), maybe new PyPy versions (PyPy3.10), new platforms (like musllinux), and removing old platforms. It's extremely helpful to pin on that. Adding new API doesn't break anyone since they aren't using it yet - normally this would be "minor" release criteria, but since we guarantee a new minor release for addition/removal of platforms, I'm saying it's possibly helpful to consider it a patch release. And we don't really make breaking API changes much (which is our "major" release criteria).

Now if we bumped the major version on every removal/addition, then we could make new features minor releases and bug fixes patch releases. But we'd have new major versions at least yearly, and maybe every few months.

I'm mostly worried about concerns like #1587; personally I get enough update PRs that this isn't a large enough fraction to worry about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants