Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bot] Update dependencies #1635

Merged
merged 1 commit into from
Oct 3, 2023
Merged

[Bot] Update dependencies #1635

merged 1 commit into from
Oct 3, 2023

Conversation

cibuildwheel-bot[bot]
Copy link
Contributor

@cibuildwheel-bot cibuildwheel-bot bot commented Oct 3, 2023 •
edited
Loading

Update the versions of our dependencies.

PR generated by "Update dependencies" workflow.

joerick
joerick approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be 3.12.0 final in completeness.

@mayeut
Copy link
Member

mayeut commented Oct 3, 2023

The manylinux build was not completely done when the update workflow was triggered.
I re-triggered the update workflow now that the manylinux build is finished.

@joerick
Copy link
Contributor

joerick commented Oct 3, 2023

Thank you @mayeut for checking that! I didn't realise how long the manylinux builds took.

@joerick
Copy link
Contributor

joerick commented Oct 3, 2023

I will get this out later today...!

@henryiii
Copy link
Contributor

henryiii commented Oct 3, 2023

I think the top 8 PRs are ready to go in. (Personally really would like the schema cleanup before a released version with the old schema goes out ;) ).

@joerick joerick merged commit 035f5a2 into main Oct 3, 2023
19 checks passed
@joerick joerick deleted the update-dependencies-pr branch October 3, 2023 17:12
@joerick
Copy link
Contributor

joerick commented Oct 3, 2023

Thank you for your PR reviews while I was away on holiday @henryiii!

@joerick
Copy link
Contributor

joerick commented Oct 3, 2023

v2.16.2 released.

@ddelange
Copy link

hi 👋

in this PR, I observed v2.16.2 not yet producing cp312 wheels although it is in general availability now.

Is it still hardcoded as an unreleased python version somewhere in this codebase?

@joerick
Copy link
Contributor

joerick commented Oct 18, 2023 •
edited
Loading

That linked PR appears to pin an old version of cibuildwheel, 2.12.0

https://github.com/vaexio/vaex/blob/b2d83ac0d62309533e449a7a50b464e33c1ac980/.github/workflows/wheel.yml#L26C32-L26C46

@ddelange
Copy link

ah damn, good catch! thanks for the quick reply 🙏

@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayeut mayeut mayeut approved these changes

@joerick joerick joerick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mayeut @joerick @henryiii @ddelange