Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize local requirements when creating a wheel or sdist #1545

Closed
wants to merge 1 commit into from

Conversation

idlsoft
Copy link

@idlsoft idlsoft commented May 31, 2024

When building a wheel or a source distribution local source dependencies like my_lib @ ../my_lib will be converted to regular dependencies like my_lib == 1.0.0.

This would make it easier to release multiple inter-dependent libraries

@idlsoft idlsoft marked this pull request as draft June 1, 2024 04:31
@idlsoft idlsoft closed this Jun 1, 2024
@ofek
Copy link
Collaborator

ofek commented Jun 1, 2024

?

@idlsoft
Copy link
Author

idlsoft commented Jun 1, 2024

?

I don't think it's fully cooked yet.

It handles a very specific criteria to post-process dependencies.

There's work being done to have a proper cargo-like workspace for python. In that context the criteria of what a local dependency is would be very different.

It may be more useful to open this up to hooks and leave the function as one of the possible implementations.

@ofek
Copy link
Collaborator

ofek commented Jun 1, 2024

FYI Hatch intends to provide such an experience for Python (the idea and project predates UV). I think you are right that this PR would have been insufficient and actually I'm working on the workspaces feature today, as we speak!

@idlsoft
Copy link
Author

idlsoft commented Jun 3, 2024

I'm working on the workspaces feature today, as we speak!

That's great, can't believe this is still uncommon.
I tidied it up a bit, for some reason it wouldn't allow me to re-open this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants