MAINT: Convert manually cached BuilderConfig properties to cached_property #1760
+483
−581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maresb
force-pushed
the
cached-properties
branch
4 times, most recently
from
60bde5a
to
fae7a25
Compare
Before we cached the empty list and returned None to prevent recomputation in case None was cached.
maresb
force-pushed
the
cached-properties
branch
from
fae7a25
to
cd9f32c
Compare
|
Rebased on |
maresb
force-pushed
the
cached-properties
branch
from
cd9f32c
to
4e4bc47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working up to some other contributions, but wanted to do some preliminary cleanup.
Unless I screwed something up, this is a pure refactor, completely equivalent to the previous code, just a bit more tidy thanks to Python 3.8 features.