Skip to content

chore: drop duplicate PLR1714 ruff rule - #14933

Merged
Pierre-Sassoulas merged 2 commits into
pytest-dev:mainfrom
even-even:chore/drop_duplicate_PLR_ruff_rules
Aug 27, 2026
Merged

chore: drop duplicate PLR1714 ruff rule#14933
Pierre-Sassoulas merged 2 commits into
pytest-dev:mainfrom
even-even:chore/drop_duplicate_PLR_ruff_rules

Conversation

@even-even

Copy link
Copy Markdown
Contributor

Problem

after https://github.com/pytest-dev/pytest/pull/12622/changes#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R107 "PLR1714" ruff rule doesn't need. "PLR1714" include in "PLR" ruff rules.

Fix

delete twice "PLR1714"

Tests

Снимок экрана 2026-08-25 в 00 51 53

Also: after delete PLR1714 pyproject-fmt was formatting lint.extend-select block.

@RonnyPfannschmidt

Copy link
Copy Markdown
Member

Unattended unattributed

@RonnyPfannschmidt

Copy link
Copy Markdown
Member

after email exchange i consider this human after all
lets till crop down the description to something actually human - a slightly shorter statement of the problem is enough - pre-commit is tested and visible on ci, fix is self-evident and the cursed 3 part of problem/fix/validation is an ai slop bingo hit

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

@Pierre-Sassoulas Pierre-Sassoulas added the skip news used on prs to opt out of the changelog requirement label Aug 27, 2026
@Pierre-Sassoulas
Pierre-Sassoulas merged commit fdba12e into pytest-dev:main Aug 27, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news used on prs to opt out of the changelog requirement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants