Styling #301
Open
Styling #301
+73
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2023 13:59
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
guibescos
reviewed
Dec 12, 2023
| @@ -294,10 +296,14 @@ function LockedModalButton({ | |||
| } | |||
| className="m-4" | |||
| > | |||
| Unstake all | |||
| <span className="relative inline-flex items-center whitespace-nowrap"> | |||
There was a problem hiding this comment.
<span className="relative inline-flex items-center whitespace-nowrap"> could be refactored I guess
guibescos
reviewed
Dec 12, 2023
| @@ -46,7 +46,7 @@ const Header = () => { | |||
| </Link> | |||
| </div> | |||
| <div className="flex items-center justify-end space-x-2"> | |||
| <div className="flex w-[200px] justify-end"> | |||
| <div className="solana-wallet-button flex w-[200px] justify-end [&_button]:!rounded-none"> | |||
There was a problem hiding this comment.
Why !rounded_none, I'm curious
There was a problem hiding this comment.
LOL seems like it's to give more priority to the style and override another rule
There was a problem hiding this comment.
lets not do it this way, this is not very friendly to future maintainers, we can just override the solana-wallet-button class in globals.css
guibescos
reviewed
Dec 12, 2023
There was a problem hiding this comment.
CI and Vercel comments. I don't know about removing the rounding, let's see what @cctdaniel thinks.
cctdaniel
reviewed
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some style updates to make site consistent with pyth-web