-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add market_schedule module #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be missing context, but is the string format for these holiday schedules defined anywhere or is it being introduced by this PR? I think it would be worth using a parsing library here to make the parsing a bit more robust. While FromStr
is the right place to put this code I think handling parsing more robustly via something like winnow
might be the right thing to do to define this format more concretely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
This add marker_schedule module and renames the old schedule to legacy_schedule.
It uses a new metadata key
schedule
and it is backward compatible by falling back toweekly_schedule
metadata key.