v2.0.0 nitpicks #78
Merged
v2.0.0 nitpicks #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drozdziak1
commented
Jul 20, 2023
| # key_store.publish_keypair_path = "none" # I do not exist, remote loading activated for the network | ||
|
|
||
| # Relative path to accumulator message buffer program ID. Setting this | ||
| # Pubkey of accumulator message buffer program ID. Setting this |
There was a problem hiding this comment.
The older ordering of these options made additional exporter.* and oracle.* options fall under the remote_keypair_loader section. This means that if someone were to uncomment all config options and sections, they would not end up with a correct config.
With this change, every config section is clearly marked and additional {primary|secondary}_network options exist in the correct spot, still under [primary_network]
jayantk
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change contains small fixes to sample pythnet config, the general
config.tomland fixes confusingoracle.rslog messages. Additionally, package version is bumped tov2.0.1