Changes to remove config models. - #29
Draft
TeresiaOlsson wants to merge 1 commit into
Draft
Conversation
TeresiaOlsson
force-pushed
the
remove-configmodels
branch
from
August 27, 2026 11:12
46e0757 to
2bf5236
Compare
Documentation build overview
16 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have started a PR to remove the config models and include the changes for the schema registry to work for this packages.
It should maybe not be merged until a new release of pyaml has been done since it needs the validation model of pyaml.
@gupichon I have one problem with the static catalog where I'm not sure about the best solution. It includes:
As I understand it
self._refs[key]returns aDeviceAccessobject which doesn't have an interface for returning the configuration of it. I guess it only has worked so far becauseDeviceAccesshas been inherited and the subclasses have all implemented a_cfgattribute despite that it's not part of the defined interface. So now when there is no_cfganymore, what should actually be returned here? And maybe that should be included in theDeviceAccessinterface to make sure all future subclasses implement it?