Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop 3.7, add mypy test, bump reqs, etc #189

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Jun 17, 2024

Split out from #188 with a --patch checkout. This does destroy the commit history, so I might need to rewrite the history in #188 to avoid conflicts.

  • Drops python3.7 support. It still works afaik, but is a pain to test in CI.
  • Adds loose mypy run to Makefile & CI
  • Adds some type annotations
  • Adds 3.13-dev test run. It currently fails, but will pass once trio and cffi push new releases.
  • Adds blurb to readme on status of the project.
  • Bump package versions in requirements-dev.txt and requirements-dev-full.txt
  • Adds small tests to slightly bump code coverage

…t in CI.

* Adds loose mypy run to Makefile & CI
* Adds some type annotations
* Adds 3.13-dev test run. It currently fails, but will pass once trio
  and cffi push new releases.
* Adds blurb to readme on status of the project.
* Bump package versions in requirements-dev.txt and
  requirements-dev-full.txt
* Adds small tests to slightly bump code coverage
@jakkdl jakkdl requested a review from belm0 June 17, 2024 10:17
@jakkdl jakkdl mentioned this pull request Jun 17, 2024
2 tasks
Copy link
Member

@belm0 belm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

requirements-extras.in Outdated Show resolved Hide resolved
Comment on lines 76 to 77
python-version: ['3.12-dev']
python-version: ['3.13-dev']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds 3.13-dev test run. It currently fails, but will pass once trio and cffi push new releases.

I'd prefer to leave it at 3.12 for now so that all CI passes, and add a TODO pending the trio/cffi releases.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open an issue if trio/cffi have not released by the time #188 is finalized & merged

@jakkdl jakkdl changed the title drop 3.7, add mypy test, test 3.13-dev, bump reqs, etc drop 3.7, add mypy test, bump reqs, etc Jun 17, 2024
@@ -4,4 +4,5 @@ pip-tools>=5.5.0
pytest>=4.6
pytest-cov
pytest-trio>=0.5.0
trio<0.25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically this constraint should probably be in setup.py

but I suppose it gets resolved if we get the upcoming PR worked out

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, the package itself isn't non-functioning - it works plenty well with trio==0.25, and if you specify a value to strict_exception_groups there is no change in functionality at all. I could even modify the tests in this PR to pass on both <0.25 and >=0.25 and not have the requirement at all.

But I don't see much reason to push a release without #188 anyhow, so I think it's pretty moot

@belm0 belm0 merged commit 3294748 into python-trio:master Jun 18, 2024
9 checks passed
@jakkdl jakkdl deleted the ci_improvements branch June 19, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants