Remove _env instance attributes #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment on #1813 (comment).
Storing the Jinja2 Environment on class instances doesn't make sense to me. It doesn't bring any benefit. It takes up space in our code and in the class instances. And we have to explicitly remove it when pickling objects.
Remove the
_envclass instance attributes from Folium. Use theENVmodule variable instead.When we stop using the tile layer templates, we can get rid of this fully. But this PR already removes
ENVfrom thefoliummodule.We can do the same on Branca.