Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs versioning relating to "v" prefix #2018

Merged
merged 8 commits into from
Oct 28, 2024

Conversation

Conengmo
Copy link
Member

Some more tweaks to our docs versioning and the version switcher. Main issue is a mismatch in how the version is put into a string: whether a "v" prefix is included or not. In the git tag we include a "v" prefix, but in folium.__version__ we don't have that prefix.

In the new situation:

  • the git tag will include a v prefix
  • the folder in gh-pages will include a v prefix
  • all other places are without that prefix

This change is already live on the gh-pages branch, including the manually created docs for v0.18.0.

@Conengmo
Copy link
Member Author

Will self-merge this one since it's only about the documentation, and I tested this already.

@Conengmo Conengmo merged commit 08138a7 into python-visualization:main Oct 28, 2024
11 checks passed
@Conengmo Conengmo deleted the fix-docs-versioning branch October 28, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant