Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for SNI #755

Merged
merged 7 commits into from
Jul 10, 2024

Conversation

jessesightler-redhat
Copy link
Contributor

Fixes #754

Why is this needed?

Supports SNI

Proposed Changes

Add server_hostname to the wrap call

Does this PR introduce any breaking change?

No

kazoo/handlers/utils.py Outdated Show resolved Hide resolved
kazoo/tests/test_utils.py Outdated Show resolved Hide resolved
kazoo/tests/test_utils.py Outdated Show resolved Hide resolved
kazoo/tests/test_utils.py Show resolved Hide resolved
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (73309b2) to head (7969318).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
- Coverage   97.01%   96.81%   -0.20%     
==========================================
  Files          27       27              
  Lines        3549     3553       +4     
==========================================
- Hits         3443     3440       -3     
- Misses        106      113       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessesightler-redhat
Copy link
Contributor Author

Formatting issues have been resolved. I'm not sure why one of the pypi tests failed with a segfault when all of the others passed.

Copy link
Member

@StephenSorriaux StephenSorriaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. Just have some comments here and there. No worries about the segfault, the pypy testing pipeline just triggers it from time to time, it probably relates to the GA infrastructure, but I really never investigated it since I was not able to replicate it locally.

kazoo/client.py Show resolved Hide resolved
kazoo/handlers/utils.py Outdated Show resolved Hide resolved
kazoo/tests/test_utils.py Show resolved Hide resolved
kazoo/handlers/utils.py Show resolved Hide resolved
kazoo/client.py Outdated Show resolved Hide resolved
kazoo/handlers/utils.py Outdated Show resolved Hide resolved
kazoo/tests/test_utils.py Outdated Show resolved Hide resolved
kazoo/tests/test_utils.py Outdated Show resolved Hide resolved
kazoo/tests/test_utils.py Outdated Show resolved Hide resolved
kazoo/tests/test_utils.py Outdated Show resolved Hide resolved
kazoo/handlers/utils.py Outdated Show resolved Hide resolved
@jessesightler-redhat
Copy link
Contributor Author

@StephenSorriaux Thank you for the feedback. I have made several tweaks based upon your comments. Please let me know if you see any additional things that need attention.

StephenSorriaux
StephenSorriaux previously approved these changes Jul 2, 2024
Copy link
Member

@StephenSorriaux StephenSorriaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, that's great.

I will take care of doing a squash of the commits when merging, so that the final commit message follows our guidelines.

I will also wait a little for another maintainer to gives another feedback.

jeffwidman
jeffwidman previously approved these changes Jul 4, 2024
Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review it deeply as I'm not deeply familiar with SNI, but what I saw seems reasonable.

Thanks for plumbing it through and also including tests.

kazoo/handlers/utils.py Outdated Show resolved Hide resolved
kazoo/handlers/utils.py Show resolved Hide resolved
Co-authored-by: Jeff Widman <jeff@jeffwidman.com>
kazoo/handlers/utils.py Outdated Show resolved Hide resolved
kazoo/handlers/utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ceache ceache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for your contribution!

@ceache
Copy link
Contributor

ceache commented Jul 8, 2024

@StephenSorriaux I believe you wanted to handle the squash & merge?

@StephenSorriaux StephenSorriaux merged commit 273bd56 into python-zk:master Jul 10, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for SNI hostnames
5 participants