stubgen: fix FunctionContext.fullname for nested classes #17963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadrik
force-pushed
the
stubgen/nested-classes
branch
from
23a81fc
to
4f2c535
Compare
This comment has been minimized.
This comment has been minimized.
|
Could you add a test please? |
chadrik
force-pushed
the
stubgen/nested-classes
branch
from
4f2c535
to
228b4bb
Compare
This comment has been minimized.
This comment has been minimized.
chadrik
force-pushed
the
stubgen/nested-classes
branch
from
228b4bb
to
4a8827a
Compare
This comment has been minimized.
This comment has been minimized.
chadrik
force-pushed
the
stubgen/nested-classes
branch
from
4a8827a
to
f18850e
Compare
This comment has been minimized.
This comment has been minimized.
chadrik
force-pushed
the
stubgen/nested-classes
branch
from
f18850e
to
7637377
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
@hamdanal Test added and all tests passing. |
|
bump |
hamdanal
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the computation of
FunctionContext.fullnamefor nested classes.For a module named
spangle, with the following classes:The previous output for the class
Barwas"spangle.Bar"and with this fix it is now"spangle.Foo.Bar".