-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Override Option for TorchX Role #956
Conversation
This pull request was exported from Phabricator. Differential Revision: D62591176 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D62591176 |
Summary: Pull Request resolved: pytorch#956 Adds a generic way to override the internal values of the Role. Allows async overriding of role values and enable Async Packaging Differential Revision: D62591176
c31bbdc
to
4d81c76
Compare
This pull request was exported from Phabricator. Differential Revision: D62591176 |
Summary: Pull Request resolved: pytorch#956 Adds a generic way to override the internal values of the Role. Allows async overriding of role values and enable Async Packaging Reviewed By: Sanjay-Ganeshan Differential Revision: D62591176
4d81c76
to
ad30d78
Compare
This pull request was exported from Phabricator. Differential Revision: D62591176 |
Summary: Pull Request resolved: pytorch#956 Adds a generic way to override the internal values of the Role. Allows async overriding of role values and enable Async Packaging Reviewed By: Sanjay-Ganeshan Differential Revision: D62591176
ad30d78
to
b02b2f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - same as internal version
Summary: Pull Request resolved: pytorch#956 Adds a generic way to override the internal values of the Role. Allows async overriding of role values and enable Async Packaging Reviewed By: Sanjay-Ganeshan Differential Revision: D62591176
This pull request was exported from Phabricator. Differential Revision: D62591176 |
b02b2f3
to
0c8d577
Compare
Summary: Adds a generic way to override the internal values of the Role. Allows async overriding of role values and enable Async Packaging
Differential Revision: D62591176