-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Update macos runner to self hosted #6290
Conversation
Updates macos runner to new self hosted runners from AWS Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
f66c791
to
90a7d86
Compare
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Summary: Updates the runner to the latest apple silicon machines we have that also run on macOS 12.4 Similar to pytorch/vision#6290 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: #2556 Reviewed By: atalman, mthrok Differential Revision: D37999959 Pulled By: seemethere fbshipit-source-id: 01d2ff01e48dcc0c4e33ed81758886fa19642aa3
We got some weird failings which are probably unrelated:
Let me update the branch with latest main and restart tests. |
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM. We should merge on Green CI.
@seemethere Given that now we have 45 runners for M1, we would like run these tests not after merging on main but also on the PRs. This will help us move towards beta support of M1. Given our resources are still constraint, we consider running the full unit-tests on a single python config. Any thoughts on this?
Should be fine, but would still limit it to 1 python config for the time being |
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere I'm a bit confused on why this is failing. The issue seems unrelated as the changes don't affect CircleCI. Nevertheless while running the same test on main branch (see dummy PR #5009), it passes. The issue seems related to a dependency with PyTorch. Any idea? |
I think I understand the issue here, the windows runners don't have python3 installed by default so it should default to |
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
bf7e6a6
to
a30b258
Compare
Is this something we need to cherry-pick for the bugfix release @seemethere ? |
Summary: Reviewed By: datumbox Differential Revision: D38154568 fbshipit-source-id: 2772603b48352bd1dec7569a2f69cf0fe4f128c1 Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Updates macos runner to new self hosted runners from AWS
Signed-off-by: Eli Uriegas eliuriegas@fb.com