-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for instance checks on dataset wrappers #7239
Merged
Merged
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
7904ca3
add support for instance checks on dataset wrappers
pmeier cedda48
Merge branch 'main' into isinstance-dataset-wrapper
pmeier 65631d2
Merge branch 'main' into isinstance-dataset-wrapper
pmeier 111b8e6
dynamically create wrapper class
pmeier 2f4607b
Merge branch 'main' into isinstance-dataset-wrapper
pmeier 5734bd6
Merge branch 'main' into isinstance-dataset-wrapper
pmeier d59a7de
Merge branch 'main' into isinstance-dataset-wrapper
pmeier 31cc9fc
Merge branch 'main' into isinstance-dataset-wrapper
pmeier 09c07a0
cleanup detection references
pmeier 9a020c5
[PoC] eliminate double inheritance
pmeier b9e4108
Merge branch 'main' into isinstance-dataset-wrapper
pmeier 2bc0f3c
Revert "[PoC] eliminate double inheritance"
pmeier 3bcb767
add comment
pmeier 1899e5f
cleanup
pmeier bc6728a
fix comment
pmeier 5603b38
Merge branch 'main' into isinstance-dataset-wrapper
pmeier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
import os | ||
|
||
from typing import Any, Callable, List, Optional, Tuple | ||
|
||
import torch.utils.data as data | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that related or is it a drive-by?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L587 is needed to enforce the
isinstance
check works properly. L588 is a driveby.