Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecation warning to not mention ConvertImageDtype #7771

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

NicolasHug
Copy link
Member

Thanks @pmeier for the catch

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 28, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7771

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 1662679:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transform also has the warning in the doc string:

.. warning::
:class:`v2.ToTensor` is deprecated and will be removed in a future release.
Please use instead ``transforms.Compose([transforms.ToImageTensor(), transforms.ConvertImageDtype()])``.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NicolasHug NicolasHug merged commit 3966f95 into pytorch:main Jul 28, 2023
58 of 61 checks passed
@NicolasHug NicolasHug added code quality other if you have no clue or if you will manually handle the PR in the release notes labels Jul 28, 2023
@github-actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Aug 25, 2023
…7771)

Reviewed By: matteobettini

Differential Revision: D48642287

fbshipit-source-id: 209c94aade67a4af85f37ca8301b7469cf91f43e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed code quality other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants