This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Update pulse code to new instruction sytntax #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcapelluto
reviewed
Apr 3, 2020
|
|
||
| # Following variables should not be optional. | ||
| # To keep function interface constant, errors are inserted here. | ||
| # TODO: redesign this function in next release |
There was a problem hiding this comment.
I'd recommend opening an issue for this if you haven't already:)
|
The ci failures here should be fixed by: #378 |
| from qiskit.pulse.schedule import ParameterizedSchedule | ||
| from qiskit.pulse.commands import FrameChangeInstruction | ||
| from scipy.optimize import least_squares |
There was a problem hiding this comment.
The scipy import needs to be moved before the qiskit imports to fix linter errors
chriseclectic
approved these changes
Apr 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Temporary patch for Qiskit-Pulse update.
close #374
Details and comments
Refactoring of interface is planned but not now. This PR aims at making minimal change to the code to eliminate warnings caused by next terra update.
@lcapelluto will review this.