Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint only changed files #1197

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

mateossh
Copy link
Contributor

Description

Another approach to #1190.

I cherry-picked @yanfali commits from his PR, removed eslint-*-prettier packages since they won't be necessary and installed lint-staged package.

Questions:

  1. Is having concurrently task necessary in package.json? I don't think anyone would run this manually.
  2. This PR is configured to use prettier, not parallel-prettier packaged. Should I remove @mixer/parallel-prettier or use it instead of normal prettier?

@yanfali
Copy link
Collaborator

yanfali commented Oct 18, 2022

Are they equivalent. Does prettier format vue sfc? Also parallel is much faster than regular iirc on multicore systems. Might need to verify that. Benchmarks as to why to make this change? My biggest concern is sfc. If they aren't getting formatted this isn't a replacement.

this will be used to test on different machines
@mateossh mateossh marked this pull request as draft December 5, 2022 20:48
@yanfali
Copy link
Collaborator

yanfali commented Dec 6, 2022

All the white space changes and double quotes are out of scope

@mateossh
Copy link
Contributor Author

mateossh commented Dec 6, 2022

I know. I will use this patch to benchmark prettier/pprettier performance and then remove this from PR.

@yanfali
Copy link
Collaborator

yanfali commented Oct 28, 2023

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants