Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGBLight: Improve RGB Test animation #24477

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Oct 12, 2024

Description

Just for fun. The animation now cycles through all combinations of RGB, instead of just each channel individually, and also respects UG_VALU/UG_VALD rather than simply using RGBLIGHT_LIMIT_VAL.

Binary Colour
001 Red
010 Green
011 Yellow (Red+Green)
100 Blue
101 Pink (Red+Blue)
110 Cyan (Blue+Green)
111 White (Red+Green+Blue)
000 Off

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team October 12, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants