chore(governance): add scoped PR-size exception for PR #583 (#532) - #586
chore(governance): add scoped PR-size exception for PR #583 (#532)#586qnbs wants to merge 3 commits into
Conversation
check-pr-size.mjs loads config/pr-size-exceptions.json from the PR's base ref, so PR #583 cannot self-authorize this exception -- it must land on main first, then #583 rebases onto it. Scoped narrowly to PR #583 / fix/532-e2e-startup-determinism: the exact 81 files its review-convergence diff touches (no wildcard paths), a 1500-line non-exempt ceiling covering its actual 1256 meaningful lines with headroom, and 10 commits. The one new i18n key it adds (settings.data.dangerZone.factoryReset.failed, replacing a message that falsely told users after a failed factory reset "your data has not been lost") fans out across 19 locales x 3 source files, which is what pushes an otherwise ~24-file code fix past the absolute ceiling.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a base-ref-visible, tightly constrained PR-size exception for PR #583 so its reviewed architectural and localization changes can exceed the normal file-count ceiling without broadly weakening size enforcement. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Warning Review limit reachedNext included review available in 55 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 73 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Comment |
PR Summary
|
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Docker |  |
Sep 2, 2026 2:27p.m. | Review ↗ |
| Python | |
Sep 2, 2026 2:27p.m. | Review ↗ |
| Rust | |
Sep 2, 2026 2:27p.m. | Review ↗ |
| Shell | |
Sep 2, 2026 2:27p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
codeant-ai
Bot
added
the
size:M
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR adds a scoped exception for PR #583 to the pr-size-exceptions.json governance file. The structure follows the established pattern from previous exceptions.
Critical Issue Found
There's a logic error in the maxFiles configuration: it's set to 85 while the allowedPaths array contains exactly 81 entries. According to the PR description, this should be an "exact 81-file allowlist" with no wildcards. The 4-file gap between maxFiles and the actual path count would incorrectly permit files outside the intended allowlist.
Please fix this mismatch to ensure the exception enforces the exact file list as intended.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…ect locale fan-out count in reason
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ew-converged scope The prior 81-file/1500-line/10-commit entry was a snapshot before #583's substantive review convergence (the async epoch-based reset-gate redesign, retry-after-failure fixes across 9 services, and reverting the unrelated locale drift). Recomputed from the exact final head via node scripts/check-pr-size.mjs: 67 governed files, 1027 meaningful lines, 11 commits. allowedPaths verified to match the actual diff exactly (comm -3, zero discrepancy either direction).
There was a problem hiding this comment.
No application code in the PR — skipped Code Health checks.
See analysis details in CodeScene
Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="config/pr-size-exceptions.json">
<violation number="1" location="config/pr-size-exceptions.json:82">
P1: PR #583's exception will never apply while its generated locale bundles are omitted from `allowedPaths`. Add the 19 `public/locales/*/bundle.json` paths, or make path-scope validation use the same generated-artifact exclusion as the file and line counters.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
| "prNumber": 583, | ||
| "baseRef": "main", | ||
| "headRef": "fix/532-e2e-startup-determinism", | ||
| "maxFiles": 67, |
There was a problem hiding this comment.
P1: PR #583's exception will never apply while its generated locale bundles are omitted from allowedPaths. Add the 19 public/locales/*/bundle.json paths, or make path-scope validation use the same generated-artifact exclusion as the file and line counters.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At config/pr-size-exceptions.json, line 82:
<comment>PR #583's exception will never apply while its generated locale bundles are omitted from `allowedPaths`. Add the 19 `public/locales/*/bundle.json` paths, or make path-scope validation use the same generated-artifact exclusion as the file and line counters.</comment>
<file context>
@@ -79,72 +79,54 @@
- "maxFiles": 81,
- "maxCommits": 10,
- "maxNonExemptMeaningfulLines": 1500,
+ "maxFiles": 67,
+ "maxCommits": 12,
+ "maxNonExemptMeaningfulLines": 1100,
</file context>
1 participant
User description
Summary
Adds a scoped
config/pr-size-exceptions.jsonentry for PR #583 (issue #532 E2E startup/navigation nondeterminism), mirroring the precedent set by #576 for PR #564.check-pr-size.mjsloads the exception registry from the PR's base ref, so PR #583 cannot self-authorize this — it must land onmainfirst, then #583 rebases onto it so its own merge-base picks up this entry.Why #583 needs it
#583's review-convergence (CodeRabbit, cubic, and direct maintainer review) surfaced real defects requiring a genuine architectural fix — a shared IDB reset-gate covering every long-lived connection in the app (9 modules, not just the original 3), a broken E2E testid, a still-locale-dependent mobile selector, and a misleading post-failure error message needing a dedicated i18n key. That one new i18n key (
settings.data.dangerZone.factoryReset.failed) fans out across 19 locales × 3 source files (settings.json, pluscommon.json/sidebar.json— the latter two only reconciling unrelated pre-existing drift the samecheck-i18n-keys.mjs --fixinvocation surfaced), which is what pushes an otherwise ~24-file code fix past the absolute 30-file ceiling.Scope
Exact 81-file allowlist (no wildcards) matching #583's actual diff,
maxNonExemptMeaningfulLines: 1500(covers its measured 1256 lines with headroom, not a new target),maxCommits: 10. No file outside this list is admitted by the exception.Test plan
jq empty config/pr-size-exceptions.json— valid JSONallowedPathsand PR fix(e2e): eliminate WelcomePortal startup/navigation nondeterminism (#532) #583's actualgit diff --name-onlyoutputpnpm run ci:prepush— passSummary by Sourcery
Chores:
Summary by cubic
Adds a scoped PR-size exception for PR #583 (issue #532 E2E startup/navigation nondeterminism) so its fix can merge despite exceeding the default file count limit.
mainfirst; PR fix(e2e): eliminate WelcomePortal startup/navigation nondeterminism (#532) #583 rebases onto it to pick up the registry entry, sincecheck-pr-size.mjsreads from the base ref.Written for commit 3a2a82a. Summary will update on new commits.
CodeAnt-AI Description
Add a narrowly scoped size exception for PR #583
What Changed
Impact
✅ PR #583 can pass governance checks✅ Other pull requests remain subject to standard size limits✅ Prevents unapproved files from using the exception💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.