Skip to content

FROMLIST: wifi: ath12k: Set DTIM policy to stick mode for station interface - #974

Open
DaizhuangBai wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
DaizhuangBai:Set_DTIM_policy_to_stick_mode
Open

FROMLIST: wifi: ath12k: Set DTIM policy to stick mode for station interface#974
DaizhuangBai wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
DaizhuangBai:Set_DTIM_policy_to_stick_mode

Conversation

@DaizhuangBai

@DaizhuangBai DaizhuangBai commented Aug 18, 2026

Copy link
Copy Markdown

Currently, the station always follows the listen interval regardless of the DTIM value. The DTIM function does not work as expected. The default value of the listen interval is 5 so that the STA wakes up every 500ms when power save is on. This can cause a data transmission delay.

Set the DTIM policy to DTIM stick mode so that the station follows the AP DTIM interval rather than the listen interval, which is set in the peer assoc command. DTIM stick mode is preferable per the firmware team's request.

Apply this only for STA vdevs and only when STA power save is supported, to avoid affecting unsupported targets and P2P client vdevs.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3

Link: https://lore.kernel.org/all/20260717014302.284034-1-daizhuang.bai@oss.qualcomm.com/

CRs-Fixed: 4603726

…erface

Currently, the station always follows the listen interval regardless of
the DTIM value. The DTIM function does not work as expected. The default
value of the listen interval is 5 so that the STA wakes up every 500ms
when power save is on. This can cause a data transmission delay.

Set the DTIM policy to DTIM stick mode so that the station follows the AP
DTIM interval rather than the listen interval, which is set in the peer
assoc command. DTIM stick mode is preferable per the firmware team's request.

Apply this only for STA vdevs and only when STA power save is supported, to
avoid affecting unsupported targets and P2P client vdevs.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3

Link: https://lore.kernel.org/all/20260717014302.284034-1-daizhuang.bai@oss.qualcomm.com/
Signed-off-by: Daizhuang Bai <daizhuang.bai@oss.qualcomm.com>
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

1 similar comment
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4603726 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4603726

Please ensure the CR has a change task associated with at least one of the entities for this branch.

1 similar comment
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4603726 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4603726

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@qlijarvis

Copy link
Copy Markdown

PR #974 — validate-patch

PR: #974

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/all/20260717014302.284034-1-daizhuang.bai@oss.qualcomm.com/
  2. Lore link matches PR commits: Yes — diff content is identical; commit message body preserved verbatim; FROMLIST: prefix correctly added
  3. Upstream patch status: ✅ Upstreamed — Applied to ath-next as commit 4834ac1d4894a2c3513e8f28d5693170829b1e68 on 2026-07-19
  4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #974 - FROMLIST: wifi: ath12k: Set DTIM policy to stick mode for station interface
Upstream commit: https://lore.kernel.org/all/20260717014302.284034-1-daizhuang.bai@oss.qualcomm.com/
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream FROMLIST: prefix added correctly; base subject identical
Body preserves rationale All paragraphs preserved verbatim
Fixes tag present/correct No Fixes tag in upstream; none expected
Authorship preserved From: matches lore author (FROMLIST allows submitter to differ, but here they match)
Backport note (if applicable) N/A FROMLIST commit, not a backport
Link tag present Correct lore.kernel.org link added
Original author Signed-off-by Daizhuang Bai's Signed-off-by present

Diff

File Status Notes
drivers/net/wireless/ath/ath12k/mac.c Code hunks identical; context line numbers differ (3982 vs 3985) due to tree state
drivers/net/wireless/ath/ath12k/wmi.h Code hunks identical; context line numbers differ (2322 vs 2330) due to tree state

Upstream Patch Status

Community verdict:ACKed — Applied to ath-next tree as commit 4834ac1d4894a2c3513e8f28d5693170829b1e68 by Jeff Johnson on Sun, 19 Jul 2026

Review trail:

  • Reviewed-by: Baochen Qiang (Fri, 17 Jul 2026 09:59:41 +0800)
  • Reviewed-by: Rameshkumar Sundaram (Fri, 17 Jul 2026 10:29:46 +0530)
  • Applied by Jeff Johnson with message "Applied, thanks!" (Sun, 19 Jul 2026 08:02:54 -0700)

qcom-next/topics Presence

Status:Present in qcom-next
Commit found in qcom-next at df55c4b16b14e1425859edef59c6efeec6445178 (exact patch-id match per integration_presence_report.md)

Verdict

Merge as-is — This is a faithful representation of the upstream lore patch with the correct FROMLIST: prefix. The patch has been accepted upstream (applied to ath-next) and is already present in qcom-next. All commit message elements are correct, authorship is preserved, and the diff content is identical to the lore source (context line number differences are expected and legitimate).

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/all/20260717014302.284034-1-daizhuang.bai@oss.qualcomm.com/
  2. Lore link matches PR commits: Yes — diff content is identical; commit message body preserved verbatim; FROMLIST: prefix correctly added
  3. Upstream patch status: ✅ Upstreamed — Applied to ath-next as commit 4834ac1d4894a2c3513e8f28d5693170829b1e68 on 2026-07-19
  4. PR present in qcom-next/topics: Yes — Present in qcom-next at df55c4b16b14e1425859edef59c6efeec6445178

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 3c1e80ceb9fb6978aa94bc0624e7c0003f3b4f6e
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] FROMLIST: wifi: ath12k: Set DTIM policy to stick mode for present - exact patch-id match at df55c4b skipped - not checked because qcom-next already contains the change present

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 0/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

@qlijarvis

Copy link
Copy Markdown

PR #974 — checker-log-analyzer

PR: #974
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32133522750

Checker Result Summary
Checker Result Summary
checkpatch 1 warning: commit body line exceeds 75 chars
dt-binding-check ⏭️ No DT binding changes
dtb-check ⏭️ No devicetree changes
sparse-check Passed
check-uapi-headers No UAPI changes
check-patch-compliance Passed
tag-check Valid FROMLIST: prefix present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #974 - FROMLIST: wifi: ath12k: Set DTIM policy to stick mode for station interface
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/32133522750
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch 1 warning: commit body line exceeds 75 chars
dt-binding-check ⏭️ No DT binding changes
dtb-check ⏭️ No devicetree changes
sparse-check Passed
check-uapi-headers No UAPI changes
check-patch-compliance Passed
tag-check Valid FROMLIST: prefix present

❌ checkpatch

Root cause: Commit body line 14 exceeds the 75-character limit for commit message body text.

Failure details:

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#14: 
assoc command. DTIM stick mode is preferable per the firmware team's request.

94507483f08d total: 0 errors, 1 warnings, 0 checks, 30 lines checked

The offending line in the commit message body is:

assoc command. DTIM stick mode is preferable per the firmware team's request.

This line is 77 characters long (excluding the newline), exceeding the recommended 75-character limit.

Fix: Wrap the commit body text to stay within 75 characters per line:

git rebase -i c57b63497cd72a45c8992e05373f7b32901cf029
# Mark commit 94507483f08d as 'edit'
git commit --amend
# In the editor, rewrap line 14 to:
#   assoc command. DTIM stick mode is preferable per the firmware
#   team's request.
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES \
  --git c57b63497cd72a45c8992e05373f7b32901cf029..94507483f08d71e7e1665917fe70a77886a1f048

Verdict

One minor blocker to fix before merge: The commit message body has one line that exceeds 75 characters. This is a trivial formatting issue that can be resolved by rewrapping the text. The code changes are clean, and all other checkers passed successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants